@jimc avatar
UTC

Moderaptor
The Hornet (GT200, aka Love Bug) and 'Dimples' - a GTS 300
Joined: UTC
Posts: 43418
Location: Pleasant Hill, CA
 
Moderaptor
@jimc avatar
The Hornet (GT200, aka Love Bug) and 'Dimples' - a GTS 300
Joined: UTC
Posts: 43418
Location: Pleasant Hill, CA
UTC quote
jess wrote:
Because it was written as an add-on to phpBB circa 2005. It is primitive. And truthfully, pretty terrible code.

You can actually see the image if you do a preview, though.
Aha.

Quick edit coming up...
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
That would be a more effective demonstration if:

You embedded it with img tags instead.

EDIT: Your edit beat me to it.
⚠️ Last edited by jess on UTC; edited 2 times
@jimc avatar
UTC

Moderaptor
The Hornet (GT200, aka Love Bug) and 'Dimples' - a GTS 300
Joined: UTC
Posts: 43418
Location: Pleasant Hill, CA
 
Moderaptor
@jimc avatar
The Hornet (GT200, aka Love Bug) and 'Dimples' - a GTS 300
Joined: UTC
Posts: 43418
Location: Pleasant Hill, CA
UTC quote
jimc wrote:
Aha.

Quick edit coming up...
So a remembered stored image, when posted again, gets quoted.
⚠️ Last edited by jimc on UTC; edited 1 time
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
jimc wrote:
So a remembered stored image, when posted again, gets quoted.
In this case, yes, because the link is actually part of the message. And in most imagined implementations of inline photos, that would also be the case.
@jimc avatar
UTC

Moderaptor
The Hornet (GT200, aka Love Bug) and 'Dimples' - a GTS 300
Joined: UTC
Posts: 43418
Location: Pleasant Hill, CA
 
Moderaptor
@jimc avatar
The Hornet (GT200, aka Love Bug) and 'Dimples' - a GTS 300
Joined: UTC
Posts: 43418
Location: Pleasant Hill, CA
UTC quote
jess wrote:
In this case, yes, because the link is actually part of the message.
I'm going to strategically withdraw...
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
Uploads / attachments are actually closely tied to another change that I am thinking about: a replacement for the message editor. If you want to see one of the candidates, go take a look:

https://editorjs.io

Unfortunately, their main page won't load for me at home. But it works just fine at work. It's a promising editor, but the failure of their main website makes me somewhat... cautious.
@jimc avatar
UTC

Moderaptor
The Hornet (GT200, aka Love Bug) and 'Dimples' - a GTS 300
Joined: UTC
Posts: 43418
Location: Pleasant Hill, CA
 
Moderaptor
@jimc avatar
The Hornet (GT200, aka Love Bug) and 'Dimples' - a GTS 300
Joined: UTC
Posts: 43418
Location: Pleasant Hill, CA
UTC quote
Their website loaded just fine for me. Razz emoticon

Looks promising if you have the time to explore it.
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
jimc wrote:
Looks promising if you have the time to explore it.
One thing that's odd, but not necessarily negative, is that each "thing" is a separate block. Each paragraph is a block, as is each image. Or table. Or list.

Not sure if that presents any challenges, either SMoP or a challenge to users.
@guzzi_gal avatar
UTC

Ossessionato
Gigi, '13 GTS 300ie Touring
Joined: UTC
Posts: 2873
Location: Phoenix, AZ.
 
Ossessionato
@guzzi_gal avatar
Gigi, '13 GTS 300ie Touring
Joined: UTC
Posts: 2873
Location: Phoenix, AZ.
UTC quote
jess wrote:
Because it was written as an add-on to phpBB circa 2005. It is primitive. And truthfully, pretty terrible code.

You can actually see the image if you do a preview, though.
I know about the Preview thing, I use it all the time. I'm a freak that way.

I was just thinking that it would be easy to show the HTML and allow the poster to decide placement and order. However, if it isn't easy and it's not broke, it doesn't need to be fixed.
@ironfoot avatar
UTC

Molto Verboso
'07 GTS 250 - sold
Joined: UTC
Posts: 1321
Location: England
 
Molto Verboso
@ironfoot avatar
'07 GTS 250 - sold
Joined: UTC
Posts: 1321
Location: England
UTC quote
jess wrote:
... When you upload something to a topic but then don't actually post it, the attachment gets stored on the server anyway ...
I thought this might come up.

Pretty sure I've posted a couple of times over the years about how the server retains deleted attachments. I began to utilise it as a feature, and (same as swiss1939 describes) I've employed it in cases where I wanted inline images. Lots of my image posts display deleted attachments.

I don't mind fixing my images when the purge comes. I knew it might happen. Besides, my feeling is that users ought to be able to fully delete their uploads, and a regular purge of orphaned attachments takes us closer to that.
@attila avatar
UTC

Veni, Vidi, Posti
In garage: Yamaha Tricity 155 Urban 2019 - MV Agusta 125 RS 1956
Joined: UTC
Posts: 8291
Location: Latina (Italy)
 
Veni, Vidi, Posti
@attila avatar
In garage: Yamaha Tricity 155 Urban 2019 - MV Agusta 125 RS 1956
Joined: UTC
Posts: 8291
Location: Latina (Italy)
UTC quote
Ironfoot wrote:
I thought this might come up.

Pretty sure I've posted a couple of times over the years about how the server retains deleted attachments. I began to utilise it as a feature, and (same as swiss1939 describes) I've employed it in cases where I wanted inline images. Lots of my image posts display deleted attachments.

I don't mind fixing my images when the purge comes. I knew it might happen. Besides, my feeling is that users ought to be able to fully delete their uploads, and a regular purge of orphaned attachments takes us closer to that.
It happened to me too ...
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
Ironfoot wrote:
I thought this might come up.

Pretty sure I've posted a couple of times over the years about how the server retains deleted attachments. I began to utilise it as a feature, and (same as swiss1939 describes) I've employed it in cases where I wanted inline images. Lots of my image posts display deleted attachments.

I don't mind fixing my images when the purge comes. I knew it might happen. Besides, my feeling is that users ought to be able to fully delete their uploads, and a regular purge of orphaned attachments takes us closer to that.
I'm glad you mentioned it. I will proceed cautiously, then.
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
Sounds like what I'm going to have to do is compile a list of every inlined image included in a message, and cross reference that to the orphaned files list.
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
@ironfoot avatar
UTC

Molto Verboso
'07 GTS 250 - sold
Joined: UTC
Posts: 1321
Location: England
 
Molto Verboso
@ironfoot avatar
'07 GTS 250 - sold
Joined: UTC
Posts: 1321
Location: England
UTC quote
jess wrote:
I'm glad you mentioned it. I will proceed cautiously, then.
I'm happy to tidy up my posts if they get broken
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
jess wrote:
I've recently built a script to compare the actual files on the server for each user to what is recorded in the database, in an attempt to gauge this particular problem. It's in the gigabytes. Maybe tens of gigabytes. Large enough that I'm concerned about it.
Update: I've got some custom code cobbled together to hunt down every single orphaned attachment and put it back in the database. There are 34,799 orphaned attachments, and they collectively occupy about 4.1gb of storage space. Of those, about 10% are actually referenced with inline image tags in a post.

My goal now is still to delete all the orphaned files that aren't referenced in any posts.
@ironfoot avatar
UTC

Molto Verboso
'07 GTS 250 - sold
Joined: UTC
Posts: 1321
Location: England
 
Molto Verboso
@ironfoot avatar
'07 GTS 250 - sold
Joined: UTC
Posts: 1321
Location: England
UTC quote
jess wrote:
There are 34,799 orphaned attachments, and they collectively occupy about 4.1gb of storage space. Of those, about 10% are actually referenced with inline image tags in a post.
Wow, that's many more unattached inline images than I would have guessed. Must be a fairly large group of us utilising the hack?
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
I've spent pretty much the whole weekend writing and testing code, using a backup of the real database to rehearse the data ballet mosh pit.
Ironfoot wrote:
Wow, that's many more unattached inline images than I would have guessed. Must be a fairly large group of us utilising the hack?
It seems high because it's completely wrong. I was conflating the numbers. Here are some better ones:

There are 34,792 orphaned attachments. Of those, 552 appear as inline image references somewhere in a public post, and therefore aren't truly orphans, as such. They will be spared.

The remaining 34,240 will most likely be deleted, as they are essentially inaccessible to the public. I have no way of knowing if any of those are being hotlinked from offsite, as we're not keeping any kind of traffic statistics on the images in the CDN. If they are being hotlinked from offsite, then, well, those are going to go dark shortly.
@znomit avatar
UTC

Veni, Vidi, Posti
LX190 Friday afternoon special, Primavera, some pushbikes
Joined: UTC
Posts: 10058
Location: Hermit Kingdom
 
Veni, Vidi, Posti
@znomit avatar
LX190 Friday afternoon special, Primavera, some pushbikes
Joined: UTC
Posts: 10058
Location: Hermit Kingdom
UTC quote
jess wrote:
The remaining 34,240 will most likely be deleted,
Not Auntie Bessie! Crying or Very sad emoticon
@ironfoot avatar
UTC

Molto Verboso
'07 GTS 250 - sold
Joined: UTC
Posts: 1321
Location: England
 
Molto Verboso
@ironfoot avatar
'07 GTS 250 - sold
Joined: UTC
Posts: 1321
Location: England
UTC quote
jess wrote:
I've spent pretty much the whole weekend writing and testing code, using a backup of the real database to rehearse the data ballet mosh pit.
Thanks for finding and saving the old inline images and sorry for the bother. I'm not sure how many times I used that method to display pictures, could be 30 or so.
⚠️ Last edited by Ironfoot on UTC; edited 1 time
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
Ironfoot wrote:
Thanks for finding and saving the old inline images and sorry for the bother. I'm not sure how many times I used that method to display pictures, could be 30 or so.
No worries! The forum software was improved in the process, so it’s all good.
@tomjasz avatar
UTC

Grievance Farmer
Joined: UTC
Posts: 15921
 
Grievance Farmer
@tomjasz avatar
Joined: UTC
Posts: 15921
UTC quote
jess wrote:
No worries! The forum software was improved in the process, so it’s all good.
WOW! Incredible improvements! If only you were into eBikes. There's NO other forum, regardless of focus, out there like this.
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
jess wrote:
There are 34,792 orphaned attachments. Of those, 552 appear as inline image references somewhere in a public post, and therefore aren't truly orphans, as such. They will be spared.

The remaining 34,240 will most likely be deleted, as they are essentially inaccessible to the public. I have no way of knowing if any of those are being hotlinked from offsite, as we're not keeping any kind of traffic statistics on the images in the CDN. If they are being hotlinked from offsite, then, well, those are going to go dark shortly.
UPDATE: I've now removed 34,219 orphaned files from the server, and from the database as well.

I am reasonably confident that none of the orphaned files were referenced in any post anywhere on Modern Vespa. I think it's an open question as to whether they were externally linked or not.

Technically, at this moment, the files still exist. I've just moved them into a spot that can't be publicly accessed. I'll leave them there for a little while (on the off chance that I've effed something up) and then delete them permanently at some point in the future.

I still haven't written the code to purge all of the private message attachments, but there's still over a month before the deadline I've set.
@seamus26 avatar
UTC

Ossessionato
1979 P200E (sold) / ZNEN Amore 150 (sold) / Genuine Buddy 170i / Genuine Stella 4T /Aprilia Sportcity One 50
Joined: UTC
Posts: 2264
Location: Grand Rapids, MI
 
Ossessionato
@seamus26 avatar
1979 P200E (sold) / ZNEN Amore 150 (sold) / Genuine Buddy 170i / Genuine Stella 4T /Aprilia Sportcity One 50
Joined: UTC
Posts: 2264
Location: Grand Rapids, MI
UTC quote
jess wrote:
UPDATE: I've now removed 34,219 orphaned files from the server, and from the database as well.

I am reasonably confident that none of the orphaned files were referenced in any post anywhere on Modern Vespa. I think it's an open question as to whether they were externally linked or not.

Technically, at this moment, the files still exist. I've just moved them into a spot that can't be publicly accessed. I'll leave them there for a little while (on the off chance that I've effed something up) and then delete them permanently at some point in the future.

I still haven't written the code to purge all of the private message attachments, but there's still over a month before the deadline I've set.
I was going to say something really funny about teaming with Apple and using an AI system to match against a database of known image hashes, but it very quickly became less and less funny so I stopped.
@swiss1939 avatar
UTC

Ossessionato
P208, Stella VMC Stelvio 187, Stella 150, VNX1T, V9A1T, V9B1T, 02 Sportster XLH1208
Joined: UTC
Posts: 4110
Location: Staten Island, NY
 
Ossessionato
@swiss1939 avatar
P208, Stella VMC Stelvio 187, Stella 150, VNX1T, V9A1T, V9B1T, 02 Sportster XLH1208
Joined: UTC
Posts: 4110
Location: Staten Island, NY
UTC quote
Unrelated to PM changes, but can't find the bug reporting thread right now. Seems new threads created sometime in the past few days don't tally views anymore, despite having replies posted to the thread. Minor non-critical UI detail, but maybe its a symptom of something else more important broken?
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
swiss1939 wrote:
Unrelated to PM changes, but can't find the bug reporting thread right now. Seems new threads created sometime in the past few days don't tally views anymore, despite having replies posted to the thread. Minor non-critical UI detail, but maybe its a symptom of something else more important broken?
Well spotted! There was indeed a problem with the background process that tabulates the view counts and updates the topics in the database. The worst part is that there were no error logs of the problem, so it was completely invisible until you observed the zero view counts.

I've fixed the problem. Not completely sure how many view counts we lost, or if we lost any -- the (now-working) view counter processed a large backlog of view counts, but if the problem had existed for more than a few days, the older records would be purged.

Thanks very much for bringing this to my attention.
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
Also, looks like I nuked one of your sig pictures, presumably because it was an orphan. Sorry about that.
@daweiyang avatar
UTC

Hooked
Piaggio Fly150 Vespa GTV250ie
Joined: UTC
Posts: 161
Location: Urumchi,China
 
Hooked
@daweiyang avatar
Piaggio Fly150 Vespa GTV250ie
Joined: UTC
Posts: 161
Location: Urumchi,China
UTC quote
我的注册不行了,这是为什么?
@daweiyang avatar
UTC

Hooked
Piaggio Fly150 Vespa GTV250ie
Joined: UTC
Posts: 161
Location: Urumchi,China
 
Hooked
@daweiyang avatar
Piaggio Fly150 Vespa GTV250ie
Joined: UTC
Posts: 161
Location: Urumchi,China
UTC quote
I registered not line, is this why?
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
DaWeiYang wrote:
I registered not line, is this why?
I don't understand your question.
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
jess wrote:
https://editorjs.io

Unfortunately, their main page won't load for me at home. But it works just fine at work. It's a promising editor, but the failure of their main website makes me somewhat... cautious.
I finally figured out why their webpage won't load for me at home. The team that created it are Russian, and the editorjs.io website is hosted in Russia. Which is blocked on my home network.

Not entirely sure how I feel about that. It's a fine editor, but... not sure I want to open that particular can of worms.
@stickyfrog avatar
UTC

Moderatus Rana
MP3 250 and 2 MP3 500s
Joined: UTC
Posts: 22655
Location: Nashville, Indiana
 
Moderatus Rana
@stickyfrog avatar
MP3 250 and 2 MP3 500s
Joined: UTC
Posts: 22655
Location: Nashville, Indiana
UTC quote
jess wrote:
I finally figured out why their webpage won't load for me at home. The team that created it are Russian, and the editorjs.io website is hosted in Russia. Which is blocked on my home network.

Not entirely sure how I feel about that. It's a fine editor, but... not sure I want to open that particular can of worms.
I think caution is prudent in this case.
@seamus26 avatar
UTC

Ossessionato
1979 P200E (sold) / ZNEN Amore 150 (sold) / Genuine Buddy 170i / Genuine Stella 4T /Aprilia Sportcity One 50
Joined: UTC
Posts: 2264
Location: Grand Rapids, MI
 
Ossessionato
@seamus26 avatar
1979 P200E (sold) / ZNEN Amore 150 (sold) / Genuine Buddy 170i / Genuine Stella 4T /Aprilia Sportcity One 50
Joined: UTC
Posts: 2264
Location: Grand Rapids, MI
UTC quote
External inline image provided by member with no explanatory text

[Insert Soviet Coding Joke Here]
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote


Just a friendly reminder: You now have about two weeks to retrieve any images attached to PMs. After that, they will be deleted from the server.
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
Bump.

Last chance to save any images in PMs.
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
One more day before PM Image Doomsday!
@mtoakey avatar
UTC

Florida Man
MP3 500 HPE Sport Advanced
Joined: UTC
Posts: 30
Location: Homestead, Florida
 
Florida Man
@mtoakey avatar
MP3 500 HPE Sport Advanced
Joined: UTC
Posts: 30
Location: Homestead, Florida
UTC quote
jess wrote:
My crack legal team (consisting of the firm Dewey, Cheatem, and Howe) ...
I agree wholeheartedly ...
On another note, I'm new, and just set up my account here, noticed that my "avatar" on each page is the wrong one AND it is clockwise 90* out of plumb.
The avatar that shows in all my posts/comments is the correct one ...
Can you guys get that fixed somehow ???

Thanks for such a great resource too.
OP
@jess avatar
UTC

Petty Tyrant
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
 
Petty Tyrant
@jess avatar
0:7 And counting
Joined: UTC
Posts: 36955
Location: Bay Area, California
UTC quote
MTOakey wrote:
On another note, I'm new, and just set up my account here, noticed that my "avatar" on each page is the wrong one AND it is clockwise 90* out of plumb.
It's showing up correctly for me:

External inline image provided by member with no explanatory text
@madison_sully avatar
UTC

Veni, Vidi, Posti
MP3 500, GTS 250 (both 2008 MY), 2013 Piaggio BV 350, 2014 Can Am Spyder RT
Joined: UTC
Posts: 7547
Location: Madison, Wisconsin
 
Veni, Vidi, Posti
@madison_sully avatar
MP3 500, GTS 250 (both 2008 MY), 2013 Piaggio BV 350, 2014 Can Am Spyder RT
Joined: UTC
Posts: 7547
Location: Madison, Wisconsin
UTC quote
jess wrote:
It's showing up correctly for me:

External inline image provided by member with no explanatory text
But what if it was *meant* to be on its side?
Just, you know, spitballing here.
@mtoakey avatar
UTC

Florida Man
MP3 500 HPE Sport Advanced
Joined: UTC
Posts: 30
Location: Homestead, Florida
 
Florida Man
@mtoakey avatar
MP3 500 HPE Sport Advanced
Joined: UTC
Posts: 30
Location: Homestead, Florida
UTC quote
jess wrote:
It's showing up correctly for me:

External inline image provided by member with no explanatory text
That is CLEARLY not supposed to be on it's side... like I said it is 90* clockwise out of plumb.
However, it is ALSO the wrong "avatar" ... should be the SAME as to the left here for my comments.
DoubleGood Design banner

Modern Vespa is the premier site for modern Vespa and Piaggio scooters. Vespa GTS300, GTS250, GTV, GT200, LX150, LXS, ET4, ET2, MP3, Fuoco, Elettrica and more.

Buy Me A Coffee
 

Shop on Amazon with Modern Vespa

Modern Vespa is a participant in the Amazon Services LLC Associates Program, an affiliate advertising program designed to provide a means for sites to earn advertising fees by advertising and linking to amazon.com


All Content Copyright 2005-2024 by Modern Vespa.
All Rights Reserved.


[ Time: 0.0398s ][ Queries: 3 (0.0040s) ][ Debug on ][ 313 ][ Thing One ]